-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MarketplaceOrdering] New command group az term
to accept/show terms
#17686
Conversation
Should we use |
use |
src/azure-cli/azure/cli/command_modules/marketplaceordering/generated/_help.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/marketplaceordering/generated/_params.py
Outdated
Show resolved
Hide resolved
Yes, it's more common to have single form noun as command group. I was think that it is more common to say |
src/azure-cli/azure/cli/command_modules/marketplaceordering/generated/_help.py
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/marketplaceordering/generated/commands.py
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/marketplaceordering/_help.py
Outdated
Show resolved
Hide resolved
@yungezz Example name needs to be updated. You might need to add a manual help file. |
Description
MarketplaceOrdering RP https://docs.microsoft.com/en-us/rest/api/marketplaceordering/marketplaceagreements, API version 2021-01-01, on Track2 SDK. CodeGen readme config file: https://github.com/Azure/azure-rest-api-specs/pull/12484/files
az term accept
covers term accpeting operation, calling into API PUT https://management.azure.com/subscriptions/{subscriptionId}/providers/Microsoft.MarketplaceOrdering/offerTypes/virtualmachine/publishers/{publisherId}/offers/{offerId}/plans/{planId}/agreements/current?api-version=2021-01-01az term show
covers term show operation, calling into API GET https://management.azure.com/subscriptions/{subscriptionId}/providers/Microsoft.MarketplaceOrdering/offerTypes/virtualmachine/publishers/{publisherId}/offers/{offerId}/plans/{planId}/agreements/current?api-version=2021-01-01offerType
is defaultvirtualmachine
, this is behavior confirmed with Marketplace team.Why this is a core module instead of extension?
Terms accepting is a general flow in mgmt plane e2e flow. It's a cross RP operation. Accepting term is a key step during RP registration, user will not able to use RP like LiftR specific commands without terms. Put it in core improving discoverability and availability to users. Secondly, marketplaceordering SDK is already a dependency in core repo from long time ago, this will not impact core package heavily.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.